Proposal: C++ API for DNMD - #65
Draft
jkoritzinsky wants to merge 5 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides a proposed C++ API that adds strongly-typed wrappers around DNMD's C API to reduce mismatches between column IDs and cursor tables, reduce the chance of misuse of APIs like
md_find_row_from_cursor(which have different requirements for table-id vs coded-index columns), and ensure more reliable handling of coded-index column values and indirection tables.This PR does not change any of DNMDs internals to use C++, only the interfaces library (and there, only a few methods as POC to show how the new API looks).